Refactor the repo/remote handling #1808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out the refactoring part of #1254 to make the whole thing a little more manageable. In short, it introduces the
Remotes
module which allows for a more flexible way to define the remote repository. TheRemote
objects can be passed via therepo
keyword tomakedocs
:The user can also define a custom
Remotes.Remote
type and overload theRemotes.repourl
andRemotes.fileurl
functions to control the link generation.We do quite a bit of special handling of GitLab, BitBucket and Azure Devops repositories, so it would probably be worth adding special
Remotes.Remote
types for each of those too.