Don't throw in source_url() due to a non-existing source file #1964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@clouds56: sorry it took me this long to get back to you on #1923, but I think this fix is more correct.
relpath_from_repo_root
andrepo_commit
are only called inedit_url
andsource_url
, and they should never get called with a non-existing file. Thatsource_url
sometimes does was an oversight from #1808.It might still be a good idea to add an
isfile(file) || error("...")
to those functions though, just to explicitly catch this case in the future, and you're welcome to update the PR with that.This should fix the CI errors you reported, which I'm testing over at JuliaLang/julia#47105.