Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc simplifications #1015

Merged
merged 2 commits into from
May 9, 2019
Merged

Misc simplifications #1015

merged 2 commits into from
May 9, 2019

Conversation

fredrikekre
Copy link
Member

See commit messages.

@fredrikekre fredrikekre requested a review from mortenpi May 8, 2019 21:45
@mortenpi mortenpi added this to the 0.23.0 milestone May 8, 2019
mortenpi
mortenpi approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I especially like the coverage cleanup.

But let's merge this after we've tagged 0.22.4 off master. Don't want to drop Julia version in patch releases.

@mortenpi
Copy link
Member

mortenpi commented May 8, 2019

Hmm. Should actually also update README and docs/src/index.md. They refer to 0.7.

@fredrikekre
Drop support and CI testing for EoL Julia version 0.7.
07f7b50 
Enable CI testing for Julia version 1.1.
@fredrikekre fredrikekre merged commit fb1962f into master May 9, 2019
@fredrikekre fredrikekre deleted the fe/misc branch May 9, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi