Build non-pages pages too in HTMLWriter #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They can then be reached via their URL, which is determined from the filename, as for the other pages. But they will not show up in the sidebar nor in the bottom navigation. If there is no filter applied, these pages may still show up in an at-contents block. In fact, this actually fixes a bug where, in the HTML output, an at-contents block would list such pages, even though the writer does not produce any `.html` files, leading to broken links in the output.
fredrikekre
reviewed
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They can then be reached via their URL, which is determined from the filename, as for the other pages. But they will not show up in the sidebar nor in the bottom navigation.
If there is no filter applied, these pages may still show up in an at-contents block. In fact, this actually fixes a bug where, in the HTML output, an at-contents block would list such pages, even though the writer does not produce any
.htmlfiles, leading to broken links in the output.My use case is to have hidden draft pages (that I actually want to use for my GSoC blog).
Close #1031.