Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SSH deploy keys from GH Actions. #1183

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Support SSH deploy keys from GH Actions. #1183

merged 1 commit into from
Nov 18, 2019

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Nov 17, 2019 •
edited by mortenpi
Loading

X-ref: #1177

@fredrikekre fredrikekre added this to the 0.24.0 milestone Nov 17, 2019
@fredrikekre fredrikekre mentioned this pull request Nov 17, 2019
Merged
@fredrikekre fredrikekre force-pushed the fe/ssh-gh-actions branch 2 times, most recently from 3209edc to 0e92e5d Compare November 17, 2019 01:41
@mortenpi
Copy link
Member

Question: I assume that with the GITHUB_TOKEN you can't push to a different repository (e.g. something like we're doing for the Julia docs)? So to support that use case with GitHub Actions, should we maybe keep the DOCUMENTER_KEY approach around even after the page triggering gets fixed?

mortenpi
mortenpi reviewed Nov 17, 2019
View reviewed changes
src/deployconfig.jl Outdated Show resolved Hide resolved
@fredrikekre fredrikekre force-pushed the fe/ssh-gh-actions branch 2 times, most recently from fdd2cbd to 4016162 Compare November 18, 2019 13:21
@fredrikekre fredrikekre merged commit 52dae55 into master Nov 18, 2019
@fredrikekre fredrikekre deleted the fe/ssh-gh-actions branch November 18, 2019 14:18
@fredrikekre fredrikekre mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi left review comments

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi