Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about doctests in docstrings #1265

Merged
merged 4 commits into from
Mar 23, 2020
Merged

Conversation

helgee
Copy link
Contributor

@helgee helgee commented Mar 20, 2020

Suggest to add modules with doctests in docstrings to the modules argument. Otherwise you get the strange situation where the doctests are not run when running makedocs but do run and potentially fail when running doctest.

CC: @fredrikekre

Suggest to add modules with doctests in docstrings to the `modules` argument. Otherwise you get the strange situation where the doctests are not run when running `makedocs` but do run and potentially fail when running `doctest`.
@mortenpi
Copy link
Member

Just to clarify: this is for when you are building docs for multiple packages at once? It should not be necessary to list all submodules of your package separately if you already have the top-level module there.

@helgee
Copy link
Contributor Author

helgee commented Mar 21, 2020

In this specific case I was completely missing the modules argument and from the docs it was not really clear (to me) that it is required.

docs/src/man/doctests.md Outdated Show resolved Hide resolved
@mortenpi mortenpi added this to the 0.24.7 milestone Mar 22, 2020
@mortenpi mortenpi merged commit e71b24d into JuliaDocs:master Mar 23, 2020
briochemc added a commit to briochemc/Documenter.jl that referenced this pull request Apr 10, 2020
* JuliaDocs-master: (138 commits)
  Add example admonition css to example build (JuliaDocs#1284)
  Pass non-standard admonition categories on in HTML output (JuliaDocs#1280)
  Suggest using the `aligned` environment (JuliaDocs#1275)
  Update DiffEq docs link (JuliaDocs#1274)
  Make Deps.pip a closure again (JuliaDocs#1240)
  Recommend Julia 1.4 in the manual (JuliaDocs#1272)
  Add note about doctests in docstrings (JuliaDocs#1265)
  Fix minted/lstlistings escaping (JuliaDocs#1269)
  Changelog for 0.24.7 (JuliaDocs#1266)
  Test with Julia 1.4 instead of 1.3 on CI (JuliaDocs#1268)
  Fix doctest testing on nightly (JuliaDocs#1267)
  remove "only" from search stop word filter (JuliaDocs#1264)
  Reorganize some Sass variables to make theming easier (JuliaDocs#1258)
  Fix outdated links in the manual (JuliaDocs#1255)
  Fix LaTeX tests for tags (JuliaDocs#1256)
  Install TagBot as a GitHub Action (JuliaDocs#1237)
  use Julia 1.3 for .travis hosting example (JuliaDocs#1235)
  Set version to 0.24.5 (JuliaDocs#1233)
  Support REPL softscope for Julia 1.5. (JuliaDocs#1232)
  Discourage use of matrix: in Travis conf (JuliaDocs#1231)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants