Don't warn on 302 redirects #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fredrikekre
approved these changes
Jun 21, 2020
|
The CI failures are unrelated I believe: it's the usual intermittent failure we see on Travis. We should probably disable the linkcheck test that actually tries to connect to an external server on Travis, and maybe run it as part of the Linkcheck GitHub Actions workflow instead. LGTM, I'm fine with treating 302 |
|
bump? |
fredrikekre
approved these changes
Jun 24, 2020
|
I just noticed that 307 is also "Temporary Redirect (since HTTP/1.1)". I guess we should also disable the warning for 307 redirects? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
302s are meant to be temporary redirects, so we shouldn't warn. Fixes #1344.