Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct render code block with tag "```julia-repl XXX" #1392

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Correct render code block with tag "```julia-repl XXX" #1392

merged 1 commit into from
Aug 13, 2020

Conversation

likanzhan
Copy link
Contributor

To correct render the code block with the following formatted tag:

```Julia-repl XXXX

```

such as ```julia-repl sayhello2 in the metaprogramming manual.

 To render the code block with the following formatted tag correctly:

````
```Julia-repl XXXX


```

````
@mortenpi mortenpi added Format: LaTeX Related to the LaTeX / PDF output Type: Bug labels Aug 9, 2020
@mortenpi
Copy link
Member

Interestingly, we accidentally handle this case in the HTML output, because e.g. code[".language-julia-repl XXXX"] drops everything after the space.

LGTM. Allowing for non-language information after the language name is also hinted at in the CommonMark spec.

@mortenpi mortenpi added this to the 0.25.2 milestone Aug 11, 2020
@mortenpi mortenpi merged commit b0163f8 into JuliaDocs:master Aug 13, 2020
mortenpi added a commit that referenced this pull request Aug 13, 2020
mortenpi added a commit that referenced this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: LaTeX Related to the LaTeX / PDF output Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants