Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deploying from Buildkite. #1469

Merged
merged 5 commits into from
Nov 13, 2020

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Nov 10, 2020

Modeled after GitLab, but I left out the slug and source since they seemed unused anyway.
Example of successful run: https://buildkite.com/julialang/cuda-dot-jl/builds/116

@maleadt
Copy link
Contributor Author

maleadt commented Nov 10, 2020

Looks like this doesn't work on a non-PR:

[Info: �[22m�[39mDeploying to GitHub
┌Info: �[22m�[39m
│Buildkite config:
│  Commit branch: "master"
│  Pull request: "false"
│  Commit tag: ""
│Detected build type: preview
│- ✘ ENV["BUILDKITE_PULL_REQUEST"]="false" is a number
│- ✔ `push_preview` keyword argument to deploydocs is `true`
│- ✔ ENV["DOCUMENTER_KEY"] exists
└Deploying to folder "previews/PR0": ✘�
[36m�[1m[ �[22m�[39mInfo: �[22m�[39mDeploying to GitHub
┌Info: �[22m�[39m
│Buildkite config:
│  Commit branch: "master"
│  Pull request: "false"
│  Commit tag: ""
│Detected build type: preview
│- ✘ ENV["BUILDKITE_PULL_REQUEST"]="false" is a number
│- ✔ `push_preview` keyword argument to deploydocs is `true`
│- ✔ ENV["DOCUMENTER_KEY"] exists
└Deploying to folder "previews/PR0": ✘

I guess I need to filter out the PR if it's set to false.

@mortenpi mortenpi added this to the 0.26.0 milestone Nov 10, 2020
@mortenpi
Copy link
Member

Can't really test it myself, but LGTM. If it works and is good to go, them I'm happy to merge.

@jakebolewski
Copy link

LGTM, it would be great to tag a release after this is merged if possible. Currently the Clima project mocks the equiv. Travis CI env variables.

@mortenpi
Copy link
Member

it would be great to tag a release after this is merged if possible.

0.26 is still some ways out, but I think we can backport this and a few other PRs and release 0.25.4 over the weekend or so.

@mortenpi mortenpi modified the milestones: 0.26.0, 0.25.4 Nov 11, 2020
@mortenpi mortenpi merged commit d046f46 into JuliaDocs:master Nov 13, 2020
@maleadt maleadt deleted the tb/buildkite branch November 13, 2020 07:00
mortenpi pushed a commit that referenced this pull request Nov 13, 2020
@mortenpi mortenpi mentioned this pull request Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants