Add hljs class to all code blocks #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: (The green color is just to show what is highlighted with the code color). |
fredrikekre
force-pushed
the
fe/hljs
branch
2 times, most recently
from
e386f6d
to
10cddab
Compare
This adds hljs to all code blocks for two reasons: - nohighlight blocks are left untouched by HighlightJS, meaning that the hljs class isn't attached at runtime to those blocks. Adding this explicitly makes sure that CSS rules for code blocks still apply such that the correct "regular text color" is used. - If JavaScript is disabled in the browser this makes sure that at least the intended "regular text color" is used for code blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds hljs to all code blocks for two reasons:
the hljs class isn't attached at runtime to those blocks. Adding this
explicitly makes sure that CSS rules for code blocks still apply
such that the correct "regular text color" is used.
least the intended "regular text color" is used for code blocks.