Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove index.html #1658

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Conversation

hyrodium
Copy link
Contributor

If #1657 is merged, index.html will be maintained by Documenter.jl.

We have the folllowing two options, and I choose the first one:

  • Delete index.html and Documenter.jl will generate this file again.
    • 👍 The author of commit will be Documenter.jl.
    • 👎 We will lose the redirect page in short time.
  • Modify index.html and add a comment <!--This file is automatically generated by Documenter.jl--> to be maintaned by Documenter.jl
    • 👍 We don't lost the redirect page.
    • 👎 The author of commit will be human.

@fredrikekre
Copy link
Member

I suggest we just add the documenter comment once the other pr is merged instead of deleting this.

@hyrodium
Copy link
Contributor Author

Thanks for the review. I've updated the file.

@hyrodium
Copy link
Contributor Author

I think we can merge this PR before #1657.

@fredrikekre fredrikekre merged commit e1e9966 into JuliaDocs:gh-pages Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants