-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy button for code blocks #1748
Conversation
I think it looks better with a copy icon like in #1454 instead of |
Could the button be added only if javascript is enabled (i.e. at "runtime")? I did that here https://github.com/fredrikekre/fredrikekre.se/blob/master/_libs/clipboard.js for example. The way I did it there I don't need to do any unescaping, or include the code twice (once printed without colors as you do here IIUC). But maybe thats just because I used https://clipboardjs.com/ which handles that for me? Any reason not to use that? |
Sure, we can do that as well. |
Nice, add a changelog entry? |
Ah, looks like a CSS problem. In the dark theme |
Fixes #1055.