allow deploy docs on schedule #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add the |
Ianlmgoddard
commented
Mar 8, 2022
test/deployconfig.jl
Outdated
| d = Documenter.deploy_folder(cfg; repo="github.com/JuliaDocs/Documenter.jl.git", | ||
| devbranch="master", devurl="dev", push_preview=true, | ||
| deploy_on_schedule=false) | ||
| @test !d.all_ok |
There was a problem hiding this comment.
Might be better to explicitly test that this failed because the event name schedule isn't accepted when deploy_on_schedule=false.
|
I think it shouldn't be configurable in Documenter. If you don't want doc builds for scheduled workflows that should be configured in the workflow file instead IMO. |
Fair enough! I've redone the PR to be basically equivalent to #1554. Only real difference is the addition of a test to ensure all checks pass when the event is |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
deploy_on_schedulekwarg todeploydocsanddeploy_folder. This lets the user deploy documentation from scheduled github actions.I'm added some tests to check that the kwarg works as expected for
deploy_folder. I couldn't see where the tests were fordeploydocsbut if tests exist for that function then I should probably add to them.Also I think this a feature bump? unsure, any advice is appreciated.
closes #1772.