Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force code padding #1774

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Force code padding #1774

merged 2 commits into from
Mar 17, 2022

Conversation

pfitzseb
Copy link
Member

@pfitzseb pfitzseb commented Mar 9, 2022

No description provided.

@fredrikekre
Copy link
Member

I suppose this makes it slightly more awkward to override these things yourself. Perhaps better to just modify my CSS file?

@pfitzseb
Copy link
Member Author

pfitzseb commented Mar 9, 2022

Yea, I think that'd be better.

@pfitzseb pfitzseb closed this Mar 9, 2022
@pfitzseb
Copy link
Member Author

pfitzseb commented Mar 9, 2022

Although maybe not? I've removed the offending line in the original PR too, so maybe it should be fixed in the Documenter CSS directly.

@fredrikekre
Copy link
Member

What was your conclusion here? 🙂

@pfitzseb pfitzseb reopened this Mar 15, 2022
@pfitzseb
Copy link
Member Author

I think this PR is fine -- you can still override the styling, but it'll just work with upstream themes.

@fredrikekre fredrikekre merged commit 5b3b619 into master Mar 17, 2022
@fredrikekre fredrikekre deleted the sp/force-code-padding branch March 17, 2022 11:05
@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Bugfix labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants