Memoize result value in Utilities.getremote #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me, could just use a small CHANGELOG note. |
fredrikekre
force-pushed
the
fe/cache-remote
branch
from
6a9e7c2
to
000548b
Compare
Utilities.getremote is called when figuring out the URL to methods while rendering the documentation. A profile of makedocs for Documenters docs showed that almost a third of the collected samples was inside getremote, and in particular in the spawned process to git. This patch memoizes the result of getremote (on a per-source-file basis). This should give noticeable improvements, since this function is often often called with the same argument.
fredrikekre
force-pushed
the
fe/cache-remote
branch
from
000548b
to
ff385cf
Compare
KristofferC
approved these changes
Jun 5, 2022
fredrikekre
added a commit
that referenced
this pull request
Jun 5, 2022
Utilities.getremote is called when figuring out the URL to methods while rendering the documentation. A profile of makedocs for Documenters docs showed that almost a third of the collected samples was inside getremote, and in particular in the spawned process to git. This patch memoizes the result of getremote (on a per-source-file basis). This should give noticeable improvements, since this function is often often called with the same argument. (cherry picked from commit 14c1ef2)
fredrikekre
added a commit
that referenced
this pull request
Jun 5, 2022
Utilities.getremote is called when figuring out the URL to methods while rendering the documentation. A profile of makedocs for Documenters docs showed that almost a third of the collected samples was inside getremote, and in particular in the spawned process to git. This patch memoizes the result of getremote (on a per-source-file basis). This should give noticeable improvements, since this function is often often called with the same argument. (cherry picked from commit 14c1ef2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilities.getremote is called when figuring out the URL to methods while
rendering the documentation. A profile of makedocs for Documenters docs
showed that almost a third of the collected samples was inside getremote,
and in particular in the spawned process to git. This patch memoizes the
result of getremote. This should give noticeable improvements, since
this function is often often called with the same argument.