Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Hamburger to left #2076

Merged
merged 5 commits into from
Mar 27, 2023
Merged

Conversation

inkydragon
Copy link
Contributor

@inkydragon inkydragon commented Mar 18, 2023

fix #1312

old style

image
image

@mortenpi
Copy link
Member

The HTML implementation LGTM, but could we also retain the original size and positioning? Right now it looks a bit small, and is not quite properly aligned. Also needs a CHANGELOG note.

@inkydragon
Copy link
Contributor Author

  • it looks a bit small
  • not quite properly aligned
  • needs a CHANGELOG note

image
image

The text actually does center on it, if you type a lowercase x and then look at the centerline of the x and the centerline of the hamburger.
However, since the letters of our title are mainly above the baseline, the hamburger icon needs to be moved up a bit

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, love it! I was actually still a little bit in two minds on this, but when I pulled a demo build up on my phone, the left feels far more natural (partially probably because I'm so used to Material).

CHANGELOG.md Outdated Show resolved Hide resolved
@mortenpi mortenpi merged commit 791b3ec into JuliaDocs:master Mar 27, 2023
@inkydragon inkydragon deleted the hamburger-button branch March 28, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapsed view menu button should be on the same side as the menu
2 participants