Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping special html entites in search output #2461

Merged
merged 25 commits into from
Feb 27, 2024

Conversation

Hetarth02
Copy link
Contributor

@Hetarth02 Hetarth02 commented Feb 20, 2024

This PR aims to close Issue #2441 and Issue #2428 .

2024-02-24 Edit: Fixes only Issue #2441.

@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Bugfix labels Feb 21, 2024
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that it fixes #2441, but not #2428:

image

To repro, I just added a

### ↔ ↔ ↔

heading into the Markdown source.

assets/html/js/search.js Outdated Show resolved Hide resolved
@Hetarth02
Copy link
Contributor Author

I can confirm that it fixes #2441, but not #2428:

image

To repro, I just added a

### ↔ ↔ ↔

heading into the Markdown source.

Case 1

I looked into this a little bit and I found out that, when enter into .md files and render

### ↔ ↔ ↔

I cannot find it in the search using harr or .
But it renders in html as the symbol.

For ref, see below images.

HTML Renders

image

image

Search

image

image

Case 2

But when I enter below into .md files and render

### ↔ ↔ ↔

I can find it in the search using harr but not using .
Also it does not renders in html as the symbol.

For ref, see below images.

HTML Renders

image

image

Search

image

image

@mortenpi mortenpi enabled auto-merge (squash) February 27, 2024 12:42
@mortenpi mortenpi merged commit 786cdba into JuliaDocs:master Feb 27, 2024
21 of 22 checks passed
@Hetarth02 Hetarth02 deleted the Issue-2441 branch June 13, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants