Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some deprecations #624

Merged
merged 5 commits into from
Jan 17, 2018
Merged

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Jan 12, 2018

Building the docs on CI results in a huge amount of depwarn again, fixed most of them.

Needs JuliaLang/Compat.jl#452 to pass on julia 0.6

It would be nice with a new release with this and 611aa82 which should silence most of the warnings.

@mortenpi mortenpi added this to the 0.13.0 milestone Jan 13, 2018
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It would be nice with a new release with this and 611aa82 which should silence most of the warnings.

Will do.

@fredrikekre
Copy link
Member Author

Tests pass now, but there was a newer nightly on macOS, which also included some recent find* changes, should be fixed with JuliaLang/Compat.jl#457 so we could either wait for that or merge this and fix that in a separate PR.

@JeffBezanson
Copy link
Contributor

Thanks for this! I suspect these deprecations are slowing down the doc build in julia CI quite a bit, so would be good to get this released as soon as possible.

@KristofferC
Copy link
Member

Looks like DocStringExtensions need to be fixed as well?

Stacktrace:
 [1] <(::Int64, ::Nothing) at ./operators.jl:227
 [2] >(::Nothing, ::Int64) at ./operators.jl:250
 [3] keywords(::Function, ::Method) at /home/travis/.julia/v0.7/DocStringExtensions/src/utilities.jl:252
.
.

on Travis

@fredrikekre
Copy link
Member Author

Yes, I am waiting for JuliaLang/Compat.jl#457 for that

@KristofferC
Copy link
Member

Ah, of course. Sorry.

@Keno
Copy link

Keno commented Jan 17, 2018

Can we just take the most direct route possible to getting rid of the deprecations, even if that means an ugly hack here? All the deprecation warnings are causing Base CI to time out.

@JeffBezanson
Copy link
Contributor

Seconded. This is now top priority, as it is slowing down Base development quite a bit. In many cases CI times out because of it.

@KristofferC KristofferC reopened this Jan 17, 2018
@mortenpi
Copy link
Member

The nightly test should pass now. Once it does, I'll merge and tag.

@mortenpi mortenpi merged commit 5593b8f into JuliaDocs:master Jan 17, 2018
@fredrikekre fredrikekre deleted the fe/deprecations branch January 17, 2018 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants