Consider CRLF when splitting code lines #991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that code lines ending with
# hide
were not getting hidden in the output.The problem went away if I switched from CRLF to LF line endings.
This might be related to issue #613
I think the issue is caused by
split(code, '\n')
(line 680 in expanders.jl) which assumes LF line ending.For CRLF input, code containing
... # hide
gets split to... # hide\r
and this causes the regex on line 681 to not match---this is because$
does not match\r
[ref]This PR fixes that by splitting code with
r"\r?\n"
.Minimum working example:
Ouput using master (note that last line still gets hidden correctly):
Output using PR
If LF is used, then both master and PR have the same output where code is hidden correctly