Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azadkia-Chatterjee coefficient #385

Merged
merged 8 commits into from
Aug 4, 2024
Merged

Conversation

kahaaga
Copy link
Member

@kahaaga kahaaga commented Aug 2, 2024

Implements #380.

The docs are here.

This PR contains

  • The AzadkiaChatterjeeCoefficient struct, which dispatches to association with either two or three input datasets (corresponding to pairwise or conditional association) + tests.
  • Implementations for AzadkiaChatterjeeCoefficient for both SurrogateAssociationTest (pairwise and conditional) and LocalPermutationTest (conditional) + tests.
  • A listing for AzadkiaChatterjeeCoefficient in the documentation pages.
  • Cross references in AssociationMeasure and AssociationMeasureEstimator docstrings.
  • Many runnable documentation examples that are cross-referenced everywhere necessary (example 1, example 2).

@kahaaga kahaaga changed the title Azadkia chatterjee coefficient Azadkia-Chatterjee coefficient Aug 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 98.03922% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.97%. Comparing base (a0014fc) to head (e426c5e).

Files Patch % Lines
src/methods/correlation/chatterjee.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   94.87%   94.97%   +0.10%     
==========================================
  Files         108      111       +3     
  Lines        3103     3205     +102     
==========================================
+ Hits         2944     3044     +100     
- Misses        159      161       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kahaaga kahaaga merged commit 27a2bb8 into main Aug 4, 2024
2 checks passed
@kahaaga kahaaga deleted the azadkia_chatterjee_coefficient branch August 4, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants