allow single argument for union!! and setdiff!!, add intersect!! and symdiff!!
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* union!! and setdiff!! now accept a single argument * doc string for setdiff!! corrected * new functions intersect!! and symdiff!! added
|
Thank you @matthias314, this looks great and I apologize for not noticing it earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
union!!andsetdiff!!now accept a single argument, likeunion,union!etc.A mistake in the doc string for
setdiff!!is corrected.New functions
intersect!!andsymdiff!!are added. I don't know why they were missing so far.All four functions pass all their arguments at once to the no-bang or single-bang version instead of using
foldl. I see no reason not to do it. Moreover, forsymdiff!!this preserves the order of elements whereasfoldlwould change it.This PR does not address the issue #14.