Further specializations for setindex!!
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MasonProtter Would you be able to have a look at this?:) |
|
@torfjelde can you re-trigger CI? I hope the new version of IRTools fixes the failure |
|
Alternatively you can just remove the nightly tests |
|
Uhmm am I blind? 👀 I can't find the re-run checks button 😬 Or is it maybe reserved for org supers? |
|
Thank you @MasonProtter ! Would it be possible to also make a release? |
This was referenced May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #21 (comment)
This PR adds further specializations to
possible(::typeof(__setindex!), ...)to improve selection of mutating version.For example:
is not mutating on #master but is on this branch.