simplify code for adapting (Named)Tuples and fix adapting NamedTuple() #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me. Not sure who wrote this code but @maleadt might want to check it looks ok. |
|
Sorry, forgot about this. LGTM! |
|
I know its not much, but any chance of a release including this fix? The |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplified the code for adapting Tuples and NamedTuples without breaking any of the tests (I'm not seeing any other obvious impact on inferability or allocations). I also fixed the fact that previously
adapt(NamedTuple())was returningTuple()instead ofNamedTuple()(and added a test for this).