Make ndims and parent inferrable #33
Conversation
|
Thanks. I guess this doesn't hurt, but it reminds me that we really shouldn't be using these methods here: #30 |
|
Maybe now's a good time as ever to bite that bullet; with the 1.6 upgrade requiring breaking upgrades to most downstream packages anyway. |
|
I think I don't understand the whole context. Does that mean that this PR is obsolete? Or are you proposing a different change? Anyway it is nice that Julia can now type infer broadcasted CUDA expressions, at least in my local dev version. |
|
No, this is still useful. Let me first fix CI though. |
Previously, the `@isdefined` conditionals prevented julia from inferring the type of these methods at compile time. With this change broadcast operations in CUDA.jl like `C .- a'` can now be fully inferred which was previously impossible because the BroadcastStyle (which uses ndims internally) could not be decided at compile time.
maleadt
force-pushed
the
dimensionality-inference
branch
from
6032076
to
1b99b81
Compare
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 62.85% 68.57% +5.71%
==========================================
Files 3 3
Lines 35 35
==========================================
+ Hits 22 24 +2
+ Misses 13 11 -2
Continue to review full report at Codecov.
|
|
Just went down a rabbit hole of why my |
Previously, the
@isdefinedconditionals prevented julia from inferring the type of thesemethods at compile time. With this change broadcast operations in CUDA.jl like
C .- a'can now be fully inferred which was previously impossible because the
BroadcastStyle (which uses ndims internally) could not be decided at compile time.