Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize cholcopy to avoid scalar indexing. #1716

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 2, 2023

Helps on 1.9, doesn't hurt on 1.8.

@maleadt maleadt mentioned this pull request Jan 2, 2023
6 tasks
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 59.62% // Head: 59.62% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bdff301) compared to base (9362065).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1716   +/-   ##
=======================================
  Coverage   59.62%   59.62%           
=======================================
  Files         150      150           
  Lines       12089    12090    +1     
=======================================
+ Hits         7208     7209    +1     
  Misses       4881     4881           
Impacted Files Coverage Δ
lib/cusolver/linalg.jl 84.53% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 859e5d2 into master Jan 3, 2023
@maleadt maleadt deleted the tb/cholcopy branch January 3, 2023 06:24
simonbyrne pushed a commit to simonbyrne/CUDA.jl that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant