Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and test opaque pointers #528

Merged
merged 11 commits into from
Oct 27, 2023
Merged

Support and test opaque pointers #528

merged 11 commits into from
Oct 27, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Oct 26, 2023

This PR adds initial support for opaque pointers, and testing of that through JULIA_LLVM_ARGS.

I'm also removing the Manifest as I'm fed up with trying to support older Manifests on newer versions of Julia.

@maleadt maleadt changed the title Support opaque pointers Support and test opaque pointers Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (83b5b74) 83.31% compared to head (25d5ecd) 84.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
+ Coverage   83.31%   84.45%   +1.13%     
==========================================
  Files          24       24              
  Lines        3291     3313      +22     
==========================================
+ Hits         2742     2798      +56     
+ Misses        549      515      -34     
Files Coverage Δ
src/metal.jl 72.86% <100.00%> (+0.17%) ⬆️
src/rtlib.jl 95.18% <100.00%> (+0.18%) ⬆️
src/spirv.jl 93.79% <90.00%> (+12.10%) ⬆️
src/irgen.jl 94.26% <91.66%> (+1.05%) ⬆️
src/driver.jl 89.32% <66.66%> (+0.65%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 77662ee into master Oct 27, 2023
21 checks passed
@maleadt maleadt deleted the tb/opaque branch October 27, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant