Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROCKernels backend #209

Merged
merged 18 commits into from
Mar 30, 2021
Merged

Add ROCKernels backend #209

merged 18 commits into from
Mar 30, 2021

Conversation

jpsamaroo
Copy link
Member

No description provided.

@vchuravy
Copy link
Member

Have we setup CI for this yet?

@jpsamaroo jpsamaroo force-pushed the jps/rocm branch 2 times, most recently from ed61998 to 23a5a19 Compare March 18, 2021 01:54
@jpsamaroo
Copy link
Member Author

Still have some tests I need to go through and conditionally disable, but basic functionality works.

@jpsamaroo jpsamaroo marked this pull request as ready for review March 19, 2021 20:18
@jpsamaroo
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 19, 2021
@bors
Copy link
Contributor

bors bot commented Mar 19, 2021

@jpsamaroo jpsamaroo marked this pull request as draft March 19, 2021 20:20
@jpsamaroo
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 19, 2021
@bors
Copy link
Contributor

bors bot commented Mar 19, 2021

try

Build failed:

@jpsamaroo
Copy link
Member Author

@vchuravy I'm not really sure what I'm doing here. Does bors run tests on Buildkite, or is it just using a Github CPU runner?

@DilumAluthge
Copy link
Collaborator

It does both.

@jpsamaroo
Copy link
Member Author

Oh I see, I didn't notice the statuses before.

@jpsamaroo
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 19, 2021
@bors
Copy link
Contributor

bors bot commented Mar 19, 2021

@jpsamaroo
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 19, 2021
@bors
Copy link
Contributor

bors bot commented Mar 19, 2021

@DilumAluthge
Copy link
Collaborator

Yeah, if you click on the green check or red X for the commit created by bors try, you can see all the statuses.

@jpsamaroo
Copy link
Member Author

@DilumAluthge what am I doing wrong with Pkg.build?

@DilumAluthge
Copy link
Collaborator

Looks like it fails because the HSA runtime library is not available on the CPU runners, which makes sense.

@DilumAluthge
Copy link
Collaborator

Could you modify AMDGPU.jl so that the build step of AMDGPU does not fail if the HSA runtime library is not found?

@jpsamaroo
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 29, 2021
@jpsamaroo
Copy link
Member Author

There will be some finalizer errors in the logs for 1.6; these are known issues, and don't affect general functioning.

@bors
Copy link
Contributor

bors bot commented Mar 29, 2021

try

Build failed:

@vchuravy
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Mar 29, 2021
@jpsamaroo
Copy link
Member Author

bors try

@bors
Copy link
Contributor

bors bot commented Mar 30, 2021

try

Already running a review

@jpsamaroo
Copy link
Member Author

@vchuravy I think this is ready whenever you and bors are ready.

@bors
Copy link
Contributor

bors bot commented Mar 30, 2021

try

Timed out.

@DilumAluthge
Copy link
Collaborator

Probably there is a mismatch between bors.toml and the actual status checks.

So Bors is waiting for a status check that doesn't actually exist, so it "times out".

There's some code in https://github.com/JuliaGPU/KernelAbstractions.jl/blob/master/.ci/bin/get-github-status-list.jl that will print out all valid status checks.

@jpsamaroo
Copy link
Member Author

But it was just working earlier today, and I didn't modify bors.toml. Let me try this once more quickly.

bors try

bors bot added a commit that referenced this pull request Mar 30, 2021
@bors
Copy link
Contributor

bors bot commented Mar 30, 2021

try

Build failed:

@DilumAluthge
Copy link
Collaborator

Looks like you now need at least Julia 1.6? Maybe change the Julia requirement to 1.6, and run CI on 1.6 and nightly?

.ci/develop.jl Outdated Show resolved Hide resolved
@jpsamaroo
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 30, 2021
@vchuravy
Copy link
Member

bors try

@bors
Copy link
Contributor

bors bot commented Mar 30, 2021

try

Already running a review

@vchuravy vchuravy merged commit 7b12f4d into master Mar 30, 2021
@bors bors bot deleted the jps/rocm branch March 30, 2021 14:02
@bors
Copy link
Contributor

bors bot commented Mar 30, 2021

try

Timed out.

@DilumAluthge
Copy link
Collaborator

DilumAluthge commented Mar 30, 2021

The issue with Bors seems to be that e.g. "buildkite/kernelabstractions-dot-jl/julia-v1" was renamed to "buildkite/kernelabstractions-dot-jl/cuda-julia-v1" in the .buildkite/pipeline.yml file without a corresponding update to bors.toml.

It's easy enough to fix - #230

@jpsamaroo
Copy link
Member Author

Sorry about that, and thanks for the catch and fix!

@DilumAluthge
Copy link
Collaborator

No worries at all - this is a pretty common enough task with Bors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants