-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROCKernels backend #209
Conversation
Have we setup CI for this yet? |
ed61998
to
23a5a19
Compare
Still have some tests I need to go through and conditionally disable, but basic functionality works. |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
@vchuravy I'm not really sure what I'm doing here. Does bors run tests on Buildkite, or is it just using a Github CPU runner? |
It does both. |
Oh I see, I didn't notice the statuses before. |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
Yeah, if you click on the green check or red X for the commit created by |
@DilumAluthge what am I doing wrong with |
Looks like it fails because the HSA runtime library is not available on the CPU runners, which makes sense. |
Could you modify AMDGPU.jl so that the build step of AMDGPU does not fail if the HSA runtime library is not found? |
bors try |
There will be some finalizer errors in the logs for 1.6; these are known issues, and don't affect general functioning. |
tryBuild failed: |
bors try |
bors try |
tryAlready running a review |
@vchuravy I think this is ready whenever you and bors are ready. |
tryTimed out. |
Probably there is a mismatch between So Bors is waiting for a status check that doesn't actually exist, so it "times out". There's some code in https://github.com/JuliaGPU/KernelAbstractions.jl/blob/master/.ci/bin/get-github-status-list.jl that will print out all valid status checks. |
But it was just working earlier today, and I didn't modify bors.toml. Let me try this once more quickly. bors try |
tryBuild failed: |
Looks like you now need at least Julia 1.6? Maybe change the Julia requirement to 1.6, and run CI on 1.6 and nightly? |
bors try |
bors try |
tryAlready running a review |
tryTimed out. |
The issue with Bors seems to be that e.g. It's easy enough to fix - #230 |
Sorry about that, and thanks for the catch and fix! |
No worries at all - this is a pretty common enough task with Bors! |
No description provided.