Define resize!
#436
Merged
Define resize!
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, looks like the current implementation at least passes basic tests. |
tgymnich
approved these changes
May 14, 2024
|
LGTM, Thanks! |
|
@maleadt @amontoison can this get included in a new release? It's holding up JuliaGPU/GPUArrays.jl#533, which we need to get good performance in some of our GPU calculations. Not sure if #439 indicates an issue with this PR, however. |
How exactly? GPUArrays tests the master branch of oneAPI.jl: https://github.com/JuliaGPU/GPUArrays.jl/blob/94bdb439755801041555aeac68da2448a22b2a6f/.buildkite/pipeline.yml#L34 |
|
Ah I didn't realize that, thanks for pointing that out. But anyway, still might be nice to make a new release of oneAPI.jl so end users can access this and other new features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of an implementation of
resize!foroneArray.It is similar to the implementations for
CuArray,ROCArray, andMtlArray.I don't have access to an Intel GPU so don't have any way of testing it, so the current implementation is most likely wrong. I'm hoping to get some help from someone who is capable of helping, and/or use the CI tests to guide me towards a correct implementation.
In conjunction with JuliaGPU/GPUArrays.jl#533, this will allow
append!to be defined foroneArray.@tgymnich @maleadt