Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proj.bounds function #72

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Add Proj.bounds function #72

merged 1 commit into from
Oct 20, 2022

Conversation

simonbyrne
Copy link
Contributor

Now we've upgraded the library, we can expose this interface.

See discussion in MakieOrg/GeoMakie.jl#101

Now we've upgraded the library, we can expose this interface.

See discussion in MakieOrg/GeoMakie.jl#101
@rafaqz
Copy link
Member

rafaqz commented Oct 19, 2022

There is also https://github.com/rafaqz/Extents.jl that we use in GeoInterface.jl and DimensionslData.jl/Rasters.jl for this.

It's basically bounds with a type wrapper and explicit dimension name and order

@simonbyrne
Copy link
Contributor Author

@rafaqz I'm not quite sure I understand: are you suggesting we import Extent into Proj, or import Proj into Extent?

@rafaqz
Copy link
Member

rafaqz commented Oct 19, 2022

import Extent

It's a tiny package just to have a shared wrapper for extents/bounding boxes.

Maybe I misunderstand what your bounds method is here

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for adding it!

@visr
Copy link
Member

visr commented Oct 19, 2022

@rafaqz it probably makes sense to also support Extents, but that can be done in a separate PR, right? Perhaps by adding a method to Proj.bounds that returns an Extent when that is the input? Or would this definition be in the way?

@simonbyrne
Copy link
Contributor Author

Probably best to do that as another PR?

I've opened MakieOrg/GeoMakie.jl#132, which uses this.

@rafaqz
Copy link
Member

rafaqz commented Oct 20, 2022

Yeah it can totally be in another PR, I was just pointing out we mostly are using Extent for passing around this information now in JuliaGeo.

@simonbyrne
Copy link
Contributor Author

can we merge this and tag a new release?

@visr visr merged commit 449b502 into JuliaGeo:master Oct 20, 2022
@simonbyrne simonbyrne deleted the sb/bounds branch October 25, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants