Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tag? #28

Closed
dkarrasch opened this issue Aug 20, 2018 · 8 comments
Closed

New tag? #28

dkarrasch opened this issue Aug 20, 2018 · 8 comments

Comments

@dkarrasch
Copy link
Collaborator

It seems that GeometricalPredicates.jl requires a new tag to work under Julia v1.0.

@skariel
Copy link
Contributor

skariel commented Aug 29, 2018

yep, I'll look into this

@dkarrasch
Copy link
Collaborator Author

I just checked: the master branch seems to be loadable in Julia 1.0, and tests pass once you change using Base.Test to simply using Test.

@dkarrasch
Copy link
Collaborator Author

Any progress on this? It really just requires the minor change in the tests and a new version tag. Would be cool to have it officially available.

@dkarrasch
Copy link
Collaborator Author

Things are getting serious, see here. I can't load neither GeometricalPredicates.jl nor VoronoiDelaunay.jl because of this. Can I help with anything, @skariel ?

@skariel
Copy link
Contributor

skariel commented Sep 23, 2018

@dkarrasch yeah sure, if you want to tag etc. go ahead, I'm adding you as collaborator :)

@skariel
Copy link
Contributor

skariel commented Sep 23, 2018

@dkarrasch also adding you to VoronoiDelaunay

@dkarrasch
Copy link
Collaborator Author

New tag is released, travis tests pass. Once it's integrated to METADATA, this should work in Julia v1.0.

@skariel
Copy link
Contributor

skariel commented Sep 24, 2018

@dkarrasch thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants