Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GeometricalPredicates dependency #41

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Update GeometricalPredicates dependency #41

merged 1 commit into from
Sep 23, 2018

Conversation

VPetukhov
Copy link
Contributor

GeometricalPredicates 0.0.5 doesn't support julia 1.0

@VPetukhov
Update GeometricalPredicates dependency
8b5d937 
GeometricalPredicates 0.0.5 doesn't support julia 1.0
@VPetukhov VPetukhov mentioned this pull request Sep 21, 2018
Closed
@VPetukhov
Copy link
Contributor Author

Hm, can't understand why it still have deprecations. Repo doesn't contain the code, shown in the warnings. And when I run tests locally, it passed successfully.

@dkarrasch
Copy link
Collaborator

GeometricalPredicates v0.1.0 does not work under Julia 1.0, see here, and here. The master branch there does, but GeometricalPredicates requires a new version tag, probably v0.2.0. Then this PR would require v0.2.0 for Julia 1.0. After that, it might be that this package here requires some update.

@skariel skariel merged commit 6af1d7e into JuliaGeometry:master Sep 23, 2018
@skariel
Copy link
Contributor

skariel commented Sep 23, 2018

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VPetukhov @dkarrasch @skariel