Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in README.md #329

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Fix broken link in README.md #329

merged 1 commit into from
Aug 2, 2020

Conversation

kimikage
Copy link
Contributor

The url of Julia v0.3 documentation has been changed to https://docs.julialang.org/en/v0.3/stdlib/graphics/. (release-0.3 --> v0.3)
This changes the reference from Base.Graphics to Graphics.jl, although the documentation for Graphics.jl is still incomplete.

The url of Julia v0.3 documentation has been changed to https://docs.julialang.org/en/v0.3/stdlib/graphics/. (release-0.3 --> v0.3)
This changes the reference from Base.Graphics to Graphics.jl, although the documentation for Graphics.jl is still incomplete.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.568% when pulling 99ebeaf on kimikage:patch-1 into 0b7edfe on JuliaGraphics:master.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   90.90%   90.90%           
=======================================
  Files           1        1           
  Lines         473      473           
=======================================
  Hits          430      430           
  Misses         43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7edfe...99ebeaf. Read the comment docs.

@kimikage
Copy link
Contributor Author

kimikage commented Jul 28, 2020

BTW, I will add the missing docstrings in Graphics.jl.

@lobingera
Copy link
Contributor

missing where?

@kimikage
Copy link
Contributor Author

kimikage commented Jul 28, 2020

I'm sorry if I may have been unclear.
I want to change the link destination to Graphics.jl's docs in this PR. Also, I want to avoid these warnings in "Graphics.jl".

If you prefer the Julia v0.3 documentation because the Graphics.jl documentation is incomplete, I'll complete the Graphics.jl documentation first.

Edit: cf. JuliaGraphics/Graphics.jl#22

@lobingera lobingera merged commit 0e8323f into JuliaGraphics:master Aug 2, 2020
@kimikage
Copy link
Contributor Author

kimikage commented Aug 2, 2020

Thanks!

@kimikage kimikage deleted the patch-1 branch August 2, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants