-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove methods like +(::Number, ::Point)
and update around broadcasting
#294
Remove methods like +(::Number, ::Point)
and update around broadcasting
#294
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 73.96% 73.94% -0.02%
==========================================
Files 36 36
Lines 6680 6687 +7
==========================================
+ Hits 4941 4945 +4
- Misses 1739 1742 +3 ☔ View full report in Codecov by Sentry. |
Cool, thanks! This looks like a version 4.0... :) |
Should we create a branch |
Cool, thanks! Can you do this using the commit I've just uploaded? - I've been fixing the broadcasting regressions in the docs... # -> 3.9
# rule.(between.(O - (250, 0), O + (250, 0), 0:0.01:1), -π/3)
# 4.0 ->
rule.(between.(Ref(O - (250, 0)), Ref(O + (250, 0)), 0:0.01:1), -π/3) I write the 3.9 form all the time... :) |
This PR fixes #270.
Before this PR
After this PR