Fix significant performance regression #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use EEjet for e+e-, PseudoJet for pp
Keep the main loop code cleaner by factorising the compact array updates into functions
Resolve the actual jet indexes more explicitly
It is vital that ClusterSequence is a fully concrete type. Change the constructor to be parametrised on the type of the jets themselves.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 69.98% 70.18% +0.20%
==========================================
Files 17 17
Lines 1156 1164 +8
==========================================
+ Hits 809 817 +8
Misses 347 347 ☔ View full report in Codecov by Sentry. |
Moelf
approved these changes
Oct 17, 2024
|
Thanks for checking @Moelf 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generalising
ClusterSequenceto also handle theEEJettype, thejetsmember was changed to be the abstract typeFourMomentum. This is type unstable and has a very negative impact on performance!Fix
ClusterSequenceto be parameterised, where the typeTis taken from the type of the jets passed in to the constructor.This improves performance for$pp$ and $e^+e^-$ significantly.
Further fixes are to factorise out some of the
StructArrayhandling functions inEEAlgorithm.jlto make the code logic easier to follow.