add Aqua and move test Project.toml (#290)

JuliaHEP · Oct 24, 2023 · a42abfc · a42abfc
1 parent c34dea5
commit a42abfc
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 13 deletions.
diff --git a/Project.toml b/Project.toml
@@ -29,7 +29,6 @@ xrootdgo_jll = "9d84c17e-11f2-50ef-8cc9-e9701362097f"
 [compat]
 AbstractTrees = "^0.3.0, 0.4"
 ArraysOfArrays = "^0.5.3, ^0.6"
-Arrow = "2 - 2.5"
 BitIntegers = "^0.2.6, ^0.3"
 CodecLz4 = "^0.3, ^0.4"
 CodecXz = "^0.6, ^0.7"
@@ -49,14 +48,3 @@ StructArrays = "0.6"
 Tables = "^1.0.0"
 julia = "^1.6"
 xrootdgo_jll = "^0.32.1"
-
-[extras]
-Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45"
-DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
-InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
-SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"
-Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
-Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
-
-[targets]
-test = ["Test", "Pkg", "SHA", "InteractiveUtils", "Arrow", "DataFrames"]
diff --git a/README.md b/README.md
@@ -6,6 +6,7 @@
 [![JOSS](https://joss.theoj.org/papers/bab42b0c60f9dc7ef3b8d6460bc7229c/status.svg)](https://joss.theoj.org/papers/bab42b0c60f9dc7ef3b8d6460bc7229c)
 [![Dev](https://img.shields.io/badge/docs-dev-blue.svg)](https://juliahep.github.io/UnROOT.jl/dev)
 [![Build Status](https://github.com/JuliaHEP/UnROOT.jl/workflows/CI/badge.svg)](https://github.com/JuliaHEP/UnROOT.jl/actions)
+[![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl)
 [![Codecov](https://codecov.io/gh/JuliaHEP/UnROOT.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/JuliaHEP/UnROOT.jl)
 
 UnROOT.jl is a reader for the [CERN ROOT](https://root.cern) file format

diff --git a/src/UnROOT.jl b/src/UnROOT.jl
@@ -4,7 +4,8 @@ import SentinelArrays: ChainedVector
 import Mmap: mmap
 export ROOTFile, LazyBranch, LazyTree
 
-import Base: close, keys, get, getindex, getproperty, show, length, iterate, position, ntoh
+import Base: close, keys, get, getindex, getproperty, show, length, iterate, position
+ntoh(b) = Base.ntoh(b)
 ntoh(b::Bool) = b
 reinterpret(a,b) = Base.reinterpret(a,b)
 

diff --git a/test/Aqua.jl b/test/Aqua.jl
@@ -0,0 +1,8 @@
+using Aqua
+
+@testset "Aqua.jl" begin
+    Aqua.test_all(UnROOT;
+    ambiguities = (; broken=true),
+    piracy = (; broken=true)
+    )
+end
diff --git a/test/Project.toml b/test/Project.toml
@@ -0,0 +1,14 @@
+[deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
+Arrow = "69666777-d1a9-59fb-9406-91d4454c9d45"
+DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
+InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
+LorentzVectors = "3f54b04b-17fc-5cd4-9758-90c048d965e3"
+Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
+SHA = "ea8e919c-243c-51af-8825-aaa63cd721ce"
+StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
+Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
+
+[compat]
+Aqua = "0.7"
+Arrow = "2 - 2.5"
diff --git a/test/runtests.jl b/test/runtests.jl
@@ -9,6 +9,8 @@ nthreads == 1 && @warn "Running on a single thread. Please re-run the test suite
 
 const SAMPLES_DIR = joinpath(@__DIR__, "samples")
 
+include("Aqua.jl")
+
 
 # @stack
 struct A