Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missed namespace before kOffsetP #210

Closed
Yuan-Ru-Lin opened this issue Feb 1, 2023 · 0 comments · Fixed by #211
Closed

Missed namespace before kOffsetP #210

Yuan-Ru-Lin opened this issue Feb 1, 2023 · 0 comments · Fixed by #211

Comments

@Yuan-Ru-Lin
Copy link
Member

It should be Const.kOffsetP instead of just kOffsetP at L293.

UnROOT.jl/src/root.jl

Lines 290 to 297 in 175220a

function _normalize_ftype(fType)
# Taken from uproot4; thanks Jim ;)
if Const.kOffsetL < fType < Const.kOffsetP
fType - kOffsetP
else
fType
end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing namespace before kOffsetP Yuan-Ru-Lin/UnROOT.jl
1 participant
@Yuan-Ru-Lin