Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing namespace before kOffsetP #211

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

Yuan-Ru-Lin
Copy link
Member

Resolve #210

@Moelf
Copy link
Member

Moelf commented Feb 1, 2023

thanks!!

out of curiosity did you hit a bug with some files with this? I don't think we're using this, evident the fact that CI never caught it.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 90.33% // Head: 90.33% // No change to project coverage 👍

Coverage data is based on head (6ef8aff) compared to base (175220a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          18       18           
  Lines        2091     2091           
=======================================
  Hits         1889     1889           
  Misses        202      202           
Impacted Files Coverage Δ
src/root.jl 94.27% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Yuan-Ru-Lin
Copy link
Member Author

Yes, the bug was found when I was working on a proof-of-concept project in which I processed data files of the Belle II experiment. You can check it out at https://github.com/Yuan-Ru-Lin/BelleAnalysis.jl/blob/57f8b1a984177dfa76e83d76d1cf6b0c470dc78c/examples/reconstruct_B2Kpi.jl.

@Moelf Moelf merged commit 7bf7918 into JuliaHEP:master Feb 2, 2023
@tamasgal
Copy link
Member

tamasgal commented Feb 2, 2023

Perfect,thanks! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed namespace before kOffsetP
3 participants