simple cache for ROOTFile and remove cache for TDirectory #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #272
fix #269
I looked at what we're actually indexing on a
ROOTFile
, and found out that in the case ofreading
NanoAOD
, it's just indexing"Events"
for ~1400 times, and everything else once e.g.(
Events/blah
). So I decided to just use a naive dict like this.In the following PRs I will add more robust tests so we can figure out why we had a LRU cache
for
TDirectory
and if we need one in the future, and also prevent future regression.The code logic is basically rolling back to v0.10.5 but then do a naive cache dict manually