Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default byte for fIOFeatures #117

Merged
merged 1 commit into from
Sep 27, 2021
Merged

default byte for fIOFeatures #117

merged 1 commit into from
Sep 27, 2021

Conversation

aminnj
Copy link
Member

@aminnj aminnj commented Sep 27, 2021

Closes #116

The TBranchElement_10 struct expects fIOfeatures but TBranch_12 doesn't read that field (only TBranch_13 has it):

root [11] TBranch::Class()->GetStreamerInfo(12)->ls()
root [12] TBranch::Class()->GetStreamerInfo(13)->ls()

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #117 (92f945a) into master (db89380) will increase coverage by 2.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   90.40%   92.55%   +2.15%     
==========================================
  Files          11       11              
  Lines        1355     1357       +2     
==========================================
+ Hits         1225     1256      +31     
+ Misses        130      101      -29     
Impacted Files Coverage Δ
src/bootstrap.jl 92.30% <ø> (+8.24%) ⬆️
src/io.jl 89.39% <0.00%> (-1.52%) ⬇️
src/utils.jl 100.00% <0.00%> (ø)
src/types.jl 92.20% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db89380...92f945a. Read the comment docs.

@aminnj
Copy link
Member Author

aminnj commented Sep 27, 2021

Coverage 😊

@Moelf Moelf merged commit 2f39fc9 into JuliaHEP:master Sep 27, 2021
Moelf pushed a commit to aminnj/UnROOT.jl that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read TTree from file
2 participants