Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when file is not existent #164

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

tamasgal
Copy link
Member

Fixes #163

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #164 (33936e0) into master (a878c5b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files          11       11           
  Lines        1542     1542           
=======================================
  Hits         1396     1396           
  Misses        146      146           
Impacted Files Coverage Δ
src/root.jl 93.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a878c5b...33936e0. Read the comment docs.

@tamasgal tamasgal merged commit 029e185 into master Apr 25, 2022
Moelf pushed a commit to Moelf/UnROOT.jl that referenced this pull request Jun 23, 2022
* Fix error when file is not existent

* Use SystemError instead of general error

* Add test for non-existent-file opening
Moelf pushed a commit to aminnj/UnROOT.jl that referenced this pull request Jun 23, 2022
* Fix error when file is not existent

* Use SystemError instead of general error

* Add test for non-existent-file opening
@Moelf Moelf deleted the fix-rootfile-for-nonexistent-file branch July 1, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ROOTFile creates an empty file and errors if file does not exist
1 participant