Improves streamer logic for multiple jaggednes #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for triply jagged stuff, which is buried as
vector<something>
inside nested classes.Currently only int32 and double is implemented and this needs a bigger refactoring, now that I understand a bit better a few more edge-cases.
I'll go ahead with the merge since it does not affect the existing functionality. It's clear that the implementation is suboptimal but everything is typesafe, we just need to redesign the Jagg-type-system to e.g. use parametric types for the jaggedness or so.
With this patch, KM3NeT offline ROOT files (simulation and reco) are now fully readable ;)