Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird LRU bug error #233

Merged
merged 1 commit into from
Apr 2, 2023
Merged

weird LRU bug error #233

merged 1 commit into from
Apr 2, 2023

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Apr 2, 2023

on 0.10.2 (before), when opening unrelated file, I hit:

julia> lt = LazyTree("/tmp/0A0C246F-D01B-6F4D-85E6-3A75C27C5197.root", "Events");
ERROR: KeyError: key ((ROOTFile with 1 entry and 1 streamer.
/home/akako/Documents/github/dotFiles/homedir/.julia/dev/UnROOT/test/samples/RNTuple/test_ntuple_stl_containers.root
^C└─ ntuple (ROOT::Experimental::RNTuple)
, "ntuple"), ()) not found
Stacktrace:
  [1] pop!(h::Dict{Any, Tuple{Any, LRUCache.LinkedNode{Any}, Int64}}, key::Tuple{Tuple{ROOTFile, String}, Tuple{}})
    @ Base ./dict.jl:590
  [2] _unsafe_resize!(lru::LRUCache.LRU{Any, Any}, evictions::Vector{Tuple{Any, Any}}, maxsize::Int64)
    @ LRUCache ~/.julia/packages/LRUCache/8li9I/src/LRUCache.jl:179
  [3] _unsafe_resize!
    @ ~/.julia/packages/LRUCache/8li9I/src/LRUCache.jl:176 [inlined]
  [4] get!(default::UnROOT.var"##getter#293#137"{ROOTFile, String}, lru::LRUCache.LRU{Any, Any}, key::Tuple{Tuple{ROOTFile, String}, Tuple{}})
    @ LRUCache ~/.julia/packages/LRUCache/8li9I/src/LRUCache.jl:123
  [5] _get!
    @ ~/.julia/packages/Memoization/xgAKx/src/Memoization.jl:214 [inlined]
  [6] _getindex(f::ROOTFile, s::String)
    @ UnROOT ~/.julia/packages/Memoization/xgAKx/src/Memoization.jl:209
  [7] LazyBranch(f::ROOTFile, s::String)
    @ UnROOT ~/Documents/github/dotFiles/homedir/.julia/dev/UnROOT/src/iteration.jl:125

I think our hash function somewhere is not robust enough?

@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.36 🎉

Comparison is base (9a12043) 89.10% compared to head (5d23c4f) 89.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   89.10%   89.47%   +0.36%     
==========================================
  Files          18       18              
  Lines        2166     2166              
==========================================
+ Hits         1930     1938       +8     
+ Misses        236      228       -8     
Impacted Files Coverage Δ
src/UnROOT.jl 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Moelf Moelf merged commit 2dba3b0 into master Apr 2, 2023
@tamasgal
Copy link
Member

tamasgal commented Apr 3, 2023

Oh, what the heck?

@Moelf Moelf deleted the temp_fix branch April 3, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants