-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 'sink' parameter to the LazyTree() functions to support other table/dataframe types #282
Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
according to documentation
are you sure our |
Looks good to me this PRjulia> @time LazyTree("./test/samples/NanoAODv5_sample.root", "Events", r"Muon.*");
0.041865 seconds (394.89 k allocations: 39.741 MiB)
julia> @time LazyTree("./test/samples/NanoAODv5_sample.root", "Events", r"Muon.*"; sink=DataFrame);
0.041879 seconds (394.97 k allocations: 39.748 MiB) mainjulia> @time LazyTree("./test/samples/NanoAODv5_sample.root", "Events", r"Muon.*");
0.045695 seconds (394.95 k allocations: 39.757 MiB)
julia> @time DataFrame(LazyTree("./test/samples/NanoAODv5_sample.root", "Events", r"Muon.*"); copycols=false);
0.045971 seconds (395.03 k allocations: 39.766 MiB)
julia> @time DataFrame(LazyTree("./test/samples/NanoAODv5_sample.root", "Events", r"Muon.*"); copycols=true);
0.066453 seconds (398.93 k allocations: 43.543 MiB) |
@grasph I hope you're okay with the tests and cosmetics changes I made, I think we can safely merge this and make a patch release.
we are pre 1.0 ( |
closes #280