Remove nightly Julia build from CI #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 87.44% 87.02% -0.43%
==========================================
Files 18 18
Lines 2389 2404 +15
==========================================
+ Hits 2089 2092 +3
- Misses 300 312 +12 ☔ View full report in Codecov by Sentry. |
|
CI badge doesn't show nightly fail; Revise also does what we do now: timholy/Revise.jl#799 |
|
Currently not, but it shows it from time to time ;) |
|
Here is a short discussion: https://discourse.julialang.org/t/ignoring-nightly-failure-for-ci-badge/98028 But I am not sure if we really need nightly CI of Julia at all. I have not found the results of that job helpful at all. I always ignore that ;) |
|
I kinda need it so that when new release come around it's not broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly build is often broken and the CI badge shows "failing" because it picks that up.
I don't think we need to waste resources on the nightly Julia CI anyways.