Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNTuple] refactor display and parse column flags 0x08 #316

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Mar 15, 2024

No description provided.

@Moelf Moelf changed the title [RNTuple] refactor and handle column flags 0x08 [RNTuple] refactor display and handle column flags 0x08 Mar 15, 2024
@Moelf Moelf changed the title [RNTuple] refactor display and handle column flags 0x08 [RNTuple] refactor display and parse column flags 0x08 Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 48.27586% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 85.45%. Comparing base (f6d62f5) to head (bcb47a1).

Files Patch % Lines
src/RNTuple/displays.jl 0.00% 22 Missing ⚠️
src/RNTuple/fieldcolumn_reading.jl 64.70% 6 Missing ⚠️
src/RNTuple/highlevel.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   86.16%   85.45%   -0.72%     
==========================================
  Files          18       18              
  Lines        2458     2496      +38     
==========================================
+ Hits         2118     2133      +15     
- Misses        340      363      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf Moelf merged commit 2d2acf9 into main Mar 15, 2024
7 checks passed
@Moelf Moelf deleted the refactor branch May 19, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant