Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add promote_rule for Index64 #322

Merged
merged 2 commits into from
Mar 27, 2024
Merged

add promote_rule for Index64 #322

merged 2 commits into from
Mar 27, 2024

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Mar 22, 2024

fix #321

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.75%. Comparing base (08eb84c) to head (d240f26).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   85.74%   85.75%   +0.01%     
==========================================
  Files          18       19       +1     
  Lines        2490     2492       +2     
==========================================
+ Hits         2135     2137       +2     
  Misses        355      355              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peremato
Copy link
Member

Thanks @Moelf. I works nicely!

@peremato
Copy link
Member

Would it be possible to make a new release such that I can release what I have which depends on UnROOT?

@Moelf
Copy link
Member Author

Moelf commented Mar 22, 2024

@peremato feel free to do it if you have time. I personally would try to understand if using Index64 is bad to begin with or what... but we can always fix bugs later

@Moelf
Copy link
Member Author

Moelf commented Mar 27, 2024

ok merging this because typemax(Int64) bits is more than 1 EB

@Moelf Moelf merged commit 989d038 into main Mar 27, 2024
10 checks passed
@Moelf Moelf deleted the add_promote_rule_Index64 branch March 27, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RNTuple] OutOfMemoryError in show()
2 participants