Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNTuple] upgrade to specification v1.0.0.0 #370

Merged
merged 13 commits into from
Dec 9, 2024
Merged

[RNTuple] upgrade to specification v1.0.0.0 #370

merged 13 commits into from
Dec 9, 2024

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Nov 15, 2024

Let's see if CI for ROOT C++ is happy with this.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 80.70175% with 11 lines in your changes missing coverage. Please review.

Project coverage is 83.93%. Comparing base (1ac1e44) to head (3368c8f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/RNTuple/Writing/page_writing.jl 50.00% 8 Missing ⚠️
src/RNTuple/constants.jl 50.00% 2 Missing ⚠️
src/RNTuple/bootstrap.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   84.23%   83.93%   -0.30%     
==========================================
  Files          21       21              
  Lines        3101     3082      -19     
==========================================
- Hits         2612     2587      -25     
- Misses        489      495       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf Moelf merged commit b6aa5a3 into main Dec 9, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant