Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

julia 1.7: mutable field fix #99

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Conversation

daviehh
Copy link
Contributor

@daviehh daviehh commented Jun 3, 2021

Julia 1.7 changed T.mutable: this field no longer exists:

julia> Int64.mutable
ERROR: type DataType has no field mutable
Stacktrace:
 [1] getproperty(x::Type, f::Symbol)
   @ Base ./Base.jl:28
 [2] top-level scope
   @ REPL[1]:1

Therefore, writing to bson files fails in julia 1.7/nightly.

In 1.7, there's now a function ismutabletype. This PR will use Base.ismutabletype for julia >1.7 and use T.mutable otherwise. This same approach is used in JLD2.jl here

ps. the CI roundtrip_equal(Tuple) error seems to be caused by something else...

@DilumAluthge
Copy link
Member

Bump @CarloLucibello @DhairyaLGandhi

@mauro3
Copy link
Contributor

mauro3 commented Sep 30, 2021

I built on top of this PR in PR #103.

@DhairyaLGandhi DhairyaLGandhi merged commit 23c65b3 into JuliaIO:master Oct 9, 2021
dahong67 added a commit to dahong67/CacheVariables.jl that referenced this pull request Jan 1, 2022
Issue in BSON.jl on Julia 1.7, addressed by using more recent BSON.jl.
cf. BSON issue
JuliaIO/BSON.jl#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants