Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with @save and @load #254

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Conversation

Thuener
Copy link
Contributor

@Thuener Thuener commented Apr 3, 2019

fix #253

@aramirezreyes
Copy link

"@save" and "@load" still fail 15 month later. Could someone with the powers take a look at this and suggest some improvement that makes it ready to merge?

@JeffBezanson
Copy link
Contributor

Instead of using Main, this should use the hidden argument __module__ in the macro, which will give the calling context.

src/JLD.jl Outdated Show resolved Hide resolved
src/JLD.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@cc660ae). Click here to learn what that means.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #254   +/-   ##
=========================================
  Coverage          ?   71.46%           
=========================================
  Files             ?        4           
  Lines             ?     1710           
  Branches          ?        0           
=========================================
  Hits              ?     1222           
  Misses            ?      488           
  Partials          ?        0           
Impacted Files Coverage Δ
src/JLD.jl 90.05% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc660ae...b6204cf. Read the comment docs.

@JeffBezanson JeffBezanson merged commit f905e55 into JuliaIO:master Nov 13, 2020
@avigliotti
Copy link

I am having the same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error using @save in Main
4 participants