WIP: Type system overhaul #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 86.01% 85.47% -0.55%
==========================================
Files 28 29 +1
Lines 2810 3001 +191
==========================================
+ Hits 2417 2565 +148
- Misses 393 436 +43
Continue to review full report at Codecov.
|
JonasIsensee
force-pushed
the
typesystem
branch
from
0bdd069 to
62ef4e9
Compare
make things backwards compatible fix warning fix backwards compat forgot one verify datatypes on append add Base.length definitions typo + cleanup another fix juliatype not datatype
JonasIsensee
force-pushed
the
typesystem
branch
from
2513c14 to
53f5676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experiment on JLD2's internal type representation.
Goals are to address #37 and general improvements of type reconstruction.
Central changes are that datatype objects now also contain their fieldnames + field types
and that (julia) datatypes are stored centrally in a
_juliatypesgroup.